Fix 5.x obsolete warnings #3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebrain
approved these changes
Apr 27, 2018
| /// Stores a search template that can be used to pre render search requests, | ||
| /// before they are executed and fill the search template with template parameters. | ||
| /// </summary> | ||
| [Obsolete("Removed in NEST 6.x. In NEST 6.x, use the PutScript API to store templates")] |
Contributor
There was a problem hiding this comment.
Removed in NEST 6.x, use the PutScript API to store templates
Contributor
There was a problem hiding this comment.
A few instances that have this phrasing.
Contributor
Author
There was a problem hiding this comment.
Users should continue to use PutSearchTemplate in 5.x, but when moving to 6.x, should use PutScript. I thought it was ambiguous when In NEST 6.x, is left out as to whether users should transition to PutScript now or when they move to 6.x, so thought it was clearer to indicate when users should move to using PutScript
| protected override bool ExpectIsValid => true; | ||
| protected override HttpMethod HttpMethod => HttpMethod.POST; | ||
| protected override string UrlPath => "/project/_suggest"; | ||
| protected override string UrlPath => "/project/project/_search"; |
Contributor
Author
There was a problem hiding this comment.
{index}/{type}/_search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the compile warnings from the introduction of
ObsoleteAttributeto methods and types that are removed in 6.x