Implement IUrlParameter on Time #3222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements IUrlParameter on Time so that the conversion to a string value happens when building the url. Add condition to ElasticsearchUrlFormatter to convert TimeSpan to Time unit string value when building the url. Remove special case handling for Time and TimeSpan and re-run API generation Fixes #3220
Contributor
|
Approved, needs appropriate backport to |
codebrain
approved these changes
Apr 30, 2018
russcam
added a commit
that referenced
this pull request
Apr 30, 2018
* Implement IUrlParameter on Time This commit implements IUrlParameter on Time so that the conversion to a string value happens when building the url. Add condition to ElasticsearchUrlFormatter to convert TimeSpan to Time unit string value when building the url. Remove special case handling for Time and TimeSpan and re-run API generation Fixes #3220
russcam
added a commit
that referenced
this pull request
Apr 30, 2018
* Implement IUrlParameter on Time This commit implements IUrlParameter on Time so that the conversion to a string value happens when building the url. Add condition to UrlFormatProvider to convert TimeSpan to Time unit string value when building the url. Remove special case handling for Time and TimeSpan and re-run API generation Fixes #3220
russcam
added a commit
that referenced
this pull request
Apr 30, 2018
* Implement IUrlParameter on Time This commit implements IUrlParameter on Time so that the conversion to a string value happens when building the url. Add condition to UrlFormatProvider to convert TimeSpan to Time unit string value when building the url. Remove special case handling for Time and TimeSpan and re-run API generation Fixes #3220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements IUrlParameter on Time so that the conversion to a
string value happens when building the url.
Add condition to ElasticsearchUrlFormatter to convert TimeSpan to Time unit
string value when building the url.
Remove special case handling for Time and TimeSpan and re-run API generation
Fixes #3220