Fix #3485 #3486
Merged
Fix #3485 #3486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
commented
Nov 6, 2018
| response.DebugInformation.Should().Contain("Valid NEST response"); | ||
| } | ||
| //hide | ||
| [U] public void PasswordIsNotExposedInDebugInformation() |
Member
Author
There was a problem hiding this comment.
Notice we have spaces here, since *.doc.cs have formatter off this was not fixed as part of our recent automated code cleanup commits. We really need a order file off mechanism but I have not found a way to do that in file comments or editorconfig setting. Will tweet @ jetBrainsRider to see if I missed anything and will fix this on my plane ride home for the active integration branches manually.
Member
Author
There was a problem hiding this comment.
This should now be fixed on `master" and this PR
Mpdreamz
force-pushed
the
fix/userinfo-in-url-directly-audit
branch
from
5df9491 to
9c52141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing username/pass in the
NodeUri directly bleeds intoDebugInformation.If you use
BasicAuthentication(username, password)onConnectionSettingswhich is the recommended route this does not happen.