Feature/versioned packages #3496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd introduced versioned packages on the canary build
…n doing canary builds
…t merge them into the final dll, needed for Nest.JsonNetSerializer
…net for Nest.JsonNetSerializer, remove publish from canary target
…renced through nuget
…branches, update to latest assemblyrewriter (we had this repos as 2 different projects on appveyor
Mpdreamz
added a commit
that referenced
this pull request
Nov 26, 2018
* WIP, moved to AssemblyRewriter for the merging of the main packages and introduced versioned packages on the canary build * Cleaned up targets and made versioned nuget packages only a thing when doing canary builds * allow a project to signal it wants to rewrite the dependencies but not merge them into the final dll, needed for Nest.JsonNetSerializer * fail on first error when testing nuget packages, do not rewrite json.net for Nest.JsonNetSerializer, remove publish from canary target * remove -stoponfail, should work but does not * make sure published projects do not end up being merged but stay referenced through nuget * update to latest assembly-resolver * fix code standards tests to reflect Elastic.Internal namespace * Versioned Nuget packages are now more distinct * make sure yml uses spaces, only publish artifacts on master and \d.x branches, update to latest assemblyrewriter (we had this repos as 2 different projects on appveyor (cherry picked from commit 67a2482)
Mpdreamz
added a commit
that referenced
this pull request
Nov 26, 2018
* WIP, moved to AssemblyRewriter for the merging of the main packages and introduced versioned packages on the canary build * Cleaned up targets and made versioned nuget packages only a thing when doing canary builds * allow a project to signal it wants to rewrite the dependencies but not merge them into the final dll, needed for Nest.JsonNetSerializer * fail on first error when testing nuget packages, do not rewrite json.net for Nest.JsonNetSerializer, remove publish from canary target * remove -stoponfail, should work but does not * make sure published projects do not end up being merged but stay referenced through nuget * update to latest assembly-resolver * fix code standards tests to reflect Elastic.Internal namespace * Versioned Nuget packages are now more distinct * make sure yml uses spaces, only publish artifacts on master and \d.x branches, update to latest assemblyrewriter (we had this repos as 2 different projects on appveyor (cherry picked from commit 67a2482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NESTover to https://github.com/nullean/AssemblyRewriterNESTwe buildNEST.7.1.0-ci<date>as before but alsoNEST7.7.1.0-ci<date>Elasticsearch.NetandJson.NETand moves everything into theNEST7namespace allowing side by side installs of multiple versionsStrongNamechecks were executed on the input to nuget pack, moved this to when we unpack the nuget packages and inspect the shipped dlls version numbers.