Serialize fractional numbers with trailing decimal point and value #3660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates - the DoubleToStringConverter from utf8json to always emit a trailing decimal point and trailing decimal value when serializing floating point numbers to JSON. - the DecimalFormatter from utf8json to always emit a trailing decimal point and trailing decimal value when serializing floating point numbers to JSON. Update unit tests to reflect this change Fixes #3657
Mpdreamz
approved these changes
Apr 11, 2019
| //const int max_trailing_padding_zeroes_in_precision_mode_; | ||
|
|
||
| static readonly Flags flags_ = Flags.UNIQUE_ZERO | Flags.EMIT_POSITIVE_EXPONENT_SIGN; | ||
| static readonly Flags flags_ = Flags.UNIQUE_ZERO | Flags.EMIT_POSITIVE_EXPONENT_SIGN | Flags.EMIT_TRAILING_DECIMAL_POINT | Flags.EMIT_TRAILING_ZERO_AFTER_POINT; |
Member
There was a problem hiding this comment.
So happy these flags exist and problem is solved at the root!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
always emit a trailing decimal point and trailing decimal value when
serializing floating point numbers to JSON.
point and trailing decimal value when serializing floating point numbers to JSON.
Update unit tests to reflect this change
Fixes #3657