Skip to content

Correctly deserialize Percentiles aggregate #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2019
Merged

Correctly deserialize Percentiles aggregate #3724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Nest/Aggregations/AggregateFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,9 +325,11 @@ private IAggregate GetPercentilesAggregate(ref JsonReader reader)
metric.Items.Add(new PercentileItem
{
Percentile = double.Parse(propertyName),
Value = reader.ReadDouble()
Value = reader.ReadNullableDouble()
});
}

reader.ReadNext(); // }
}
else
{
Expand All @@ -343,10 +345,12 @@ private IAggregate GetPercentilesAggregate(ref JsonReader reader)
metric.Items.Add(new PercentileItem
{
Percentile = percentile,
Value = reader.ReadDouble()
Value = reader.ReadNullableDouble()
});
reader.ReadNext(); // }
}

reader.ReadNext(); // ]
}

return metric;
Expand Down
2 changes: 1 addition & 1 deletion src/Nest/Aggregations/Metric/Percentiles/PercentilesMetricAggregate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Nest
public class PercentileItem
{
public double Percentile { get; internal set; }
public double Value { get; internal set; }
public double? Value { get; internal set; }
}

public class PercentilesAggregate : MetricAggregateBase
Expand Down
Loading