Convert SLM API dates returned as long to DateTimeOffset #4173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the SLM API responses to convert date properties that are returned long values representing milliseconds since epoch to DateTimeOffset. This is consistent with other API responses where longs are returned. What is slightly different with this API is that Human=true can be specified on the request to also return the properties as string values. With this change, the client now effectively ignores these values as they serve little purpose, since both would end up being converted to DateTimeOffset when deserialized.
russcam
added a commit
that referenced
this pull request
Oct 23, 2019
This commit updates the SLM API responses to convert date properties that are returned long values representing milliseconds since epoch to DateTimeOffset. This is consistent with other API responses where longs are returned. What is slightly different with this API is that Human=true can be specified on the request to also return the properties as string values. With this change, the client now effectively ignores these values as they serve little purpose, since both would end up being converted to DateTimeOffset when deserialized. (cherry picked from commit a2f98b6)
Contributor
Author
|
ported to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the SLM API responses to convert date properties that are returned long values representing milliseconds since epoch
to DateTimeOffset. This is consistent with other API responses where longs are returned. What is slightly different with
this API is that Human=true can be specified on the request to also return the properties as string values. With this change, the client
now effectively ignores these values as they serve little purpose, since both would end up being converted to DateTimeOffset when deserialized.