normalize ifdefs in our source included UTF8Json #4212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
suggested changes
Nov 13, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
I left some comments. Have the NETSTANDARD directive blocks been tested on net461?
Member
Author
@russcam we used to define |
russcam
approved these changes
Dec 9, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM 👍
Spoke about the NETSTANDARD constant on our weekly sync, which answered the outstanding question.
Mpdreamz
added a commit
that referenced
this pull request
Dec 10, 2019
(cherry picked from commit dd58212)
Member
Author
|
ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes most of the compiler directives known to be false for the TFM's we publish.
Removes the need to define
NETSTANDARDfor ournet41TFM.