Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Apr 13, 2020

This commit updates the custom serialization docs that discuss using
JsonNetSerializer.

  1. Remove the implication that the internal serializer
    is based on Json.NET.
  2. Include recommendation to hook up JsonNetSerializer when using
    Newtonsoft.Json.Linq types like JObject

This commit updates the custom serialization docs that discuss using
JsonNetSerializer.

1. Remove the implication that the internal serializer
is based on Json.NET.
2. Include recommendation to hook up JsonNetSerializer when using
Newtonsoft.Json.Linq types like JObject
@russcam
Copy link
Contributor Author

russcam commented Apr 15, 2020

Failures look like they're related to

org.elasticsearch.bootstrap.StartupException: java.lang.IllegalArgumentException: unknown setting [cluster.remote.connect] did you mean [cluster.remote.node.attr] A change has come in on master thats failing our integration tests.

and not this change, which is simply a doc change.

@russcam russcam merged commit 073269c into master Apr 15, 2020
@russcam russcam deleted the docs/custom-serialization branch April 15, 2020 00:26
github-actions bot pushed a commit that referenced this pull request Apr 15, 2020
This commit updates the custom serialization docs that discuss using
JsonNetSerializer.

1. Remove the implication that the internal serializer
is based on Json.NET.
2. Include recommendation to hook up JsonNetSerializer when using
Newtonsoft.Json.Linq types like JObject
github-actions bot pushed a commit that referenced this pull request Apr 15, 2020
This commit updates the custom serialization docs that discuss using
JsonNetSerializer.

1. Remove the implication that the internal serializer
is based on Json.NET.
2. Include recommendation to hook up JsonNetSerializer when using
Newtonsoft.Json.Linq types like JObject
github-actions bot pushed a commit that referenced this pull request Apr 15, 2020
This commit updates the custom serialization docs that discuss using
JsonNetSerializer.

1. Remove the implication that the internal serializer
is based on Json.NET.
2. Include recommendation to hook up JsonNetSerializer when using
Newtonsoft.Json.Linq types like JObject
russcam added a commit that referenced this pull request Apr 15, 2020
This commit updates the custom serialization docs that discuss using
JsonNetSerializer.

1. Remove the implication that the internal serializer
is based on Json.NET.
2. Include recommendation to hook up JsonNetSerializer when using
Newtonsoft.Json.Linq types like JObject

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request Apr 15, 2020
This commit updates the custom serialization docs that discuss using
JsonNetSerializer.

1. Remove the implication that the internal serializer
is based on Json.NET.
2. Include recommendation to hook up JsonNetSerializer when using
Newtonsoft.Json.Linq types like JObject

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit that referenced this pull request Apr 15, 2020
This commit updates the custom serialization docs that discuss using
JsonNetSerializer.

1. Remove the implication that the internal serializer
is based on Json.NET.
2. Include recommendation to hook up JsonNetSerializer when using
Newtonsoft.Json.Linq types like JObject

Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants