Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Apr 22, 2020

This commit adds back a RequestParams overload on NamespacedClientProxy
in Elasticsearch.Net that does not accept a content type
optional parameter, and removes the optional part
of the parameter on the other overload, for backwards
binary compatibility.

This commit adds back a RequestParams overload on NamespacedClientProxy
in Elasticsearch.Net that does not accept a content type
optional parameter, and removes the optional part
of the parameter on the other overload, for backwards
binary compatibility.
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

{
if (contentType.IsNullOrEmpty()) return requestParams;
if (contentType.IsNullOrEmpty() && accept.IsNullOrEmpty()) return requestParams;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Mpdreamz
Copy link
Member

So close to a green build:

[xUnit.net 00:05:16.6990755]     Tests.Indices.IndexManagement.SplitIndex.SplitIndexApiTests.ReturnsExpectedResponse [FAIL]
  X Tests.Indices.IndexManagement.SplitIndex.SplitIndexApiTests.ReturnsExpectedResponse [2s 995ms]
  Error Message:
   Tests.Framework.EndpointTests.ResponseAssertionException : Expected boolean to be true, but found False.
Response Under Test:
Valid NEST response built from a successful (200) low level call on PUT: /nest-fluentasync-bed1278b/_split/nest-fluentasync-bed1278b-target?pretty=true&error_trace=true
# Audit trail of this API call:
 - [1] HealthyResponse: Node: http://localhost:9200/ Took: 00:00:31.1440714
# Request:
{"settings":{"index.number_of_shards":8}}
# Response:
{
  "acknowledged" : true,
  "shards_acknowledged" : false,
  "index" : "nest-fluentasync-bed1278b-target"
}

shards_acknowledged: false

@Mpdreamz Mpdreamz merged commit a409738 into 7.x Apr 22, 2020
@Mpdreamz Mpdreamz deleted the fix/bwc-requestparams-namespacedclientproxy branch April 22, 2020 07:33
github-actions bot pushed a commit that referenced this pull request Apr 22, 2020
This commit adds back a RequestParams overload on NamespacedClientProxy
in Elasticsearch.Net that does not accept a content type
optional parameter, and removes the optional part
of the parameter on the other overload, for backwards
binary compatibility.
@russcam
Copy link
Contributor Author

russcam commented Apr 22, 2020

😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants