Consistent file string comparison across Windows and Linux #4948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a difference in the default string comparison on .NET core across Windows and Linux which was causing the Stale docs github action to fail on CI because generated documentation was ordering asciidoc includes and list items in a different order. This fix sets a specific culture to use and uses ordinal string comparison.
Mpdreamz
approved these changes
Aug 6, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Aug 6, 2020
This commit fixes a difference in the default string comparison on .NET core across Windows and Linux which was causing the Stale docs github action to fail on CI because generated documentation was ordering asciidoc includes and list items in a different order. This fix sets a specific culture to use and uses ordinal string comparison.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 6, 2020
This commit fixes a difference in the default string comparison on .NET core across Windows and Linux which was causing the Stale docs github action to fail on CI because generated documentation was ordering asciidoc includes and list items in a different order. This fix sets a specific culture to use and uses ordinal string comparison.
russcam
added a commit
that referenced
this pull request
Aug 6, 2020
…4949) This commit fixes a difference in the default string comparison on .NET core across Windows and Linux which was causing the Stale docs github action to fail on CI because generated documentation was ordering asciidoc includes and list items in a different order. This fix sets a specific culture to use and uses ordinal string comparison. Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
that referenced
this pull request
Aug 6, 2020
…4950) This commit fixes a difference in the default string comparison on .NET core across Windows and Linux which was causing the Stale docs github action to fail on CI because generated documentation was ordering asciidoc includes and list items in a different order. This fix sets a specific culture to use and uses ordinal string comparison. Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a difference in the default string comparison
on .NET core across Windows and Linux which was causing the
Stale docs github action to fail on CI because generated documentation
was ordering asciidoc includes and list items in a different order.
This fix sets a specific culture to use and uses ordinal string
comparison. Tested on Windows and Ubuntu 18.04 WSL 2.