Skip to content

Added diversified sampler aggregation #5031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2020
Merged

Added diversified sampler aggregation #5031

merged 2 commits into from
Oct 20, 2020

Conversation

@mandiscombination
Copy link
Contributor

@mandiscombination mandiscombination commented Sep 24, 2020

DiversifiedSamplerAggregation added with ExecutionHint, Field, MaxDocsPerValue, Script and ShardSize.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 24, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Mpdreamz
Mpdreamz approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @rickardp 👍 💯 !

Very complete PR, really appreciate adding the integration tests and running our unit tests and satisfying the aggregation visitor constraints to!

This made reviewing a breeze.

@Mpdreamz Mpdreamz merged commit 6fdf57a into elastic:master Oct 20, 2020
Mpdreamz added a commit that referenced this pull request Oct 20, 2020
@mandiscombination @Mpdreamz
Added diversified sampler aggregation (#5031)
4631730 
Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
(cherry picked from commit 6fdf57a)
Mpdreamz added a commit that referenced this pull request Oct 20, 2020
@mandiscombination @Mpdreamz
Added diversified sampler aggregation (#5031)
318db97 
Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
(cherry picked from commit 6fdf57a)
(cherry picked from commit 4631730)
Mpdreamz added a commit that referenced this pull request Oct 20, 2020
@mandiscombination @Mpdreamz
Added diversified sampler aggregation (#5031)
ccdfc95 
Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
(cherry picked from commit 6fdf57a)
(cherry picked from commit 4631730)
@rickardp
Copy link
Contributor

rickardp commented Nov 1, 2020

Thank you! Credit should go to my collegue @mandiscombination, I just helped with the git merge/rebase sorcery.

@rickardp rickardp deleted the add-diversified-sampler-aggregation branch November 1, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mandiscombination @elasticmachine @rickardp @Mpdreamz