Updated sampler aggregation #5032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Mpdreamz
approved these changes
Oct 20, 2020
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM, thank you for catching this @mandiscombination 👍
Member
|
Opened #5064 to |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
As highlighted by #5032
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
As highlighted by #5032
Mpdreamz
added a commit
that referenced
this pull request
Oct 20, 2020
As highlighted by #5032 Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
Mpdreamz
added a commit
that referenced
this pull request
Oct 20, 2020
As highlighted by #5032 Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecutionHint, MaxDocsPerValue and Script removed from SamplerAggregation (ShardSize is the only one valid for this type of aggregation, the rest are only for the diversified sampler).