Skip to content

Handle additional JSON properties #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Handle additional JSON properties #5139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80ae043
Handle additional JSON properties
stevejgordon Nov 30, 2020
b974fd9
PR feedback - add comment
stevejgordon Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/Nest/Aggregations/AggregateFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,24 @@ private IAggregate GetBoxplotAggregate(ref JsonReader reader, IJsonFormatterReso
reader.ReadNext(); // "q3"
reader.ReadNext(); // :
boxplot.Q3 = reader.ReadDouble();

// ES 7.11.0 adds these two additional properties on the payload
// When present on a 7.11 response, we avoid an exception by
// handling (and skipping) over the properties. The 7.11 client
// will add support for these new properties on BoxplotAggregate.
var token = reader.GetCurrentJsonToken();
if (token != JsonToken.EndObject)
{
reader.ReadNext(); // ,
reader.ReadNext(); // "lower"
reader.ReadNext(); // :
reader.ReadDouble();
reader.ReadNext(); // ,
reader.ReadNext(); // "upper"
reader.ReadNext(); // :
reader.ReadDouble();
}

return boxplot;
}

Expand Down