Skip to content

Conversation

@stevejgordon
Copy link
Contributor

No description provided.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/vsts/work/1/s/src/Elasticsearch.Net/Api/RequestParameters/RequestParameters.TextStructure.cs(61,10): error CS0246: The type or namespace name 'Format' could not be found (are you missing a using directive or an assembly reference?) 

@stevejgordon
Copy link
Contributor Author

@Mpdreamz Oops! I had a couple of issues generating originally and committed the one without that fixed type name. I've fixed it again and re-generated.

@stevejgordon stevejgordon requested a review from Mpdreamz March 1, 2021 13:16
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevejgordon
Copy link
Contributor Author

Will investigate the Linux failure on Jenkins before merging.

stevejgordon and others added 3 commits March 3, 2021 08:37
* Skip cat template YAML test (#5313)

Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
(cherry picked from commit 9251068)

* No longer fail to parse when allowed_warnings is last in the do operation definition

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
(cherry picked from commit 78a0933)
@stevejgordon stevejgordon merged commit 0017aa1 into 7.12 Mar 3, 2021
@stevejgordon stevejgordon deleted the codegen/7.12 branch March 3, 2021 13:51
github-actions bot pushed a commit that referenced this pull request Mar 3, 2021
* Generate low level client code for 7.12

* Fix type name

* Update test-matrix

* Update test matrix

* Fix parsing of some yaml tests on master (#5315)

* Skip cat template YAML test (#5313)

Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
(cherry picked from commit 9251068)

* No longer fail to parse when allowed_warnings is last in the do operation definition

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
(cherry picked from commit 78a0933)

Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
stevejgordon added a commit that referenced this pull request Mar 5, 2021
* Generate low level client code for 7.12

* Fix type name

* Update test-matrix

* Update test matrix

* Fix parsing of some yaml tests on master (#5315)

* Skip cat template YAML test (#5313)

Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
(cherry picked from commit 9251068)

* No longer fail to parse when allowed_warnings is last in the do operation definition

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
(cherry picked from commit 78a0933)

Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants