Set no BOM in editorconfig #5659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
reviewed
May 3, 2021
| insert_final_newline=true | ||
|
|
||
| [*] | ||
| charset = utf-8 |
Mpdreamz
approved these changes
May 3, 2021
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
Almost LGTM, I don't think we need to change our header to the long form. We have explicit permission to use the short format given that's what most .NET repositories use (e.g the dotnet and microsoft repositories).
stevejgordon
force-pushed
the
misc/charset-and-resharper-header
branch
from
288e42e to
e298cb1
Compare
stevejgordon
force-pushed
the
misc/charset-and-resharper-header
branch
from
e298cb1 to
ac32d90
Compare
stevejgordon
changed the title
stevejgordon
added a commit
that referenced
this pull request
May 4, 2021
stevejgordon
added a commit
that referenced
this pull request
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.editorconfigchange is applied by ReSharper code cleanup and avoid BOM changes affecting the check license headers action.