Skip to content

Conversation

@mattglet
Copy link

@mattglet mattglet commented Apr 8, 2014

In the case we have "long" IDs, we should allow for that overload.

@Mpdreamz Mpdreamz closed this in 5260861 Apr 8, 2014
@Mpdreamz
Copy link
Member

Mpdreamz commented Apr 8, 2014

Hi @mattglet

Thanks for the PR it highlighted the fact that Id parameters should be of type long and not int. I've opted not to pull your code in but hunt all instances where Id's can be passed as Id and change the type to long.

👍 Can you sign the Elasticsearch CLA in case you send more PR's in the future ?

http://www.elasticsearch.org/contributor-agreement/

Thanks!

@mattglet
Copy link
Author

mattglet commented Apr 8, 2014

Thanks @Mpdreamz, your reasoning for not pulling in the code totally makes sense... and thanks for the making the broad change! Are you planning on pushing out an updated version with this change implemented?

(also, I've signed the CLA)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants