[DOCS] Adds Connecting section to docs #6183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejgordon
requested changes
Mar 25, 2022
Contributor
stevejgordon
left a comment
stevejgordon
left a comment
There was a problem hiding this comment.
A few minor changes but otherwise LGTM! Thanks!
Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
approved these changes
Mar 25, 2022
Contributor
stevejgordon
left a comment
stevejgordon
left a comment
There was a problem hiding this comment.
LGTM! Thanks again!
szabosteve
added a commit
to szabosteve/elasticsearch-net
that referenced
this pull request
Mar 25, 2022
* [DOCS] Adds Connecting section to docs. * [DOCS] Amends ID. * [DOCS] Changes section ID. * Apply suggestions from code review Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk> * [DOCS] Addresses feedback. Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
szabosteve
added a commit
to szabosteve/elasticsearch-net
that referenced
this pull request
Mar 25, 2022
* [DOCS] Adds Connecting section to docs. * [DOCS] Amends ID. * [DOCS] Changes section ID. * Apply suggestions from code review Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk> * [DOCS] Addresses feedback. Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Mar 25, 2022
* [DOCS] Adds Connecting section to docs. * [DOCS] Amends ID. * [DOCS] Changes section ID. * Apply suggestions from code review Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk> * [DOCS] Addresses feedback. Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk> Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Mar 25, 2022
* [DOCS] Adds Connecting section to docs. * [DOCS] Amends ID. * [DOCS] Changes section ID. * Apply suggestions from code review Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk> * [DOCS] Addresses feedback. Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk> Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a
Connectingsection to the documentation.Preview
Connecting