Skip to content

Conversation

@vovikdrg
Copy link
Contributor

@vovikdrg vovikdrg commented May 8, 2014

Please check if its right way to go, and today i will be able to update some other section related to search

@Mpdreamz
Copy link
Member

Mpdreamz commented May 8, 2014

I :heart documentation PR's so many thanks for this @vovikdrg

The indentation in the code sections need to be the same (either use tabs or 4 spaces) so that the'll align correctly in the html.

Can you update this and sign the Elasticsearch CLA so that i may pull your bits in?

http://www.elasticsearch.org/contributor-agreement/

@vovikdrg
Copy link
Contributor Author

vovikdrg commented May 8, 2014

Signed, now will update tabs and dont merge it yet until i add some other changes

@Mpdreamz
Copy link
Member

@vovikdrg ping me when you feel this PR is done 👍

One thing I noticed is the code samples are indented too much

\t client.Call(s=>s
\t\t .Fluent()

In your case they are aligned to the last s of the selector which wreaks havoc on the code samples on smaller screens.

@vovikdrg
Copy link
Contributor Author

@Mpdreamz Check now. if there are any issue let me know. next week i can check documentation about mapping since now i am working with that

@vovikdrg
Copy link
Contributor Author

@Mpdreamz can you please let me know when you plan release next beta? since now i am using beta1 in my project and there is new changes which i would like to try

@Mpdreamz
Copy link
Member

Hey awesome work @vovikdrg thanks for taking my pointers on board.

documentation PR's are a rarity and I love them so huge 👍 on this.

Next beta is still a bit up in the air still debating a beta-2 or going for 1.0 full release.

Mpdreamz added a commit that referenced this pull request May 13, 2014
@Mpdreamz Mpdreamz merged commit ae21e76 into elastic:master May 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants