Skip to content

Conversation

@pquentin
Copy link
Member

It failed to provide an URL when instantiating the client, did not link to the Quickstart page and generally use older Python idioms.

It failed to provide an URL when instantiating the client, did not link
to the Quickstart page and generally use older Python idioms.
leemthompo
leemthompo previously approved these changes Nov 13, 2023
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo my inexperience with reST formatting :)

@pquentin
Copy link
Member Author

You can see the result here: https://elasticsearch-py--2373.org.readthedocs.build/en/2373/

JoshMock
JoshMock previously approved these changes Nov 13, 2023
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
@pquentin pquentin dismissed stale reviews from JoshMock and leemthompo via 439c120 November 14, 2023 02:33
@pquentin pquentin merged commit 8e7293f into elastic:main Nov 14, 2023
@pquentin pquentin deleted the fix-sphinx-index branch November 14, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants