Skip to content

Conversation

@miguelgrinberg
Copy link
Contributor

No description provided.

@miguelgrinberg miguelgrinberg requested a review from pquentin April 29, 2025 10:57
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what we had in index.rst in the past? Not sure it works well today with the DSL module in the client.

Additionally, as discussed offline, since clients are under "Reference" in elastic.co docs, maybe we should choose another name, like "API documentation" instead or "reference documentation"?

@miguelgrinberg
Copy link
Contributor Author

It isn't exactly what we had in the past, but it is close. I have removed references to "low-level client" for example. Just checked and the original wording including the reference to low-level client made it to the new docs on elastic.co as well, so I'll think about something more up to date to say as introduction and update both sides.

@miguelgrinberg miguelgrinberg force-pushed the readthedocs-intro-paragraph branch from 8eadab8 to 406a834 Compare April 29, 2025 13:49
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg merged commit 5b610f6 into elastic:main May 1, 2025
14 checks passed
@miguelgrinberg miguelgrinberg deleted the readthedocs-intro-paragraph branch May 1, 2025 08:48
github-actions bot pushed a commit that referenced this pull request May 1, 2025
miguelgrinberg added a commit that referenced this pull request May 1, 2025
(cherry picked from commit 5b610f6)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants