Always return dense vectors in searches #3125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
use-explicit-source
branch
from
d7e4562 to
6d4ea49
Compare
miguelgrinberg
commented
Oct 23, 2025
miguelgrinberg
commented
Oct 23, 2025
miguelgrinberg
commented
Oct 23, 2025
miguelgrinberg
commented
Oct 23, 2025
test_elasticsearch/test_dsl/test_integration/_async/test_search.py
Outdated
Show resolved
Hide resolved
miguelgrinberg
changed the title
pquentin
reviewed
Oct 24, 2025
test_elasticsearch/test_dsl/test_integration/_sync/test_search.py
Outdated
Show resolved
Hide resolved
github-actions bot
pushed a commit
that referenced
this pull request
Oct 24, 2025
* Pass explicit field list in document searches * more fixes * use exclude_vectors=False * remove unneeded source call * add missing type hint (cherry picked from commit cac7ace)
miguelgrinberg
added a commit
that referenced
this pull request
Oct 24, 2025
* Pass explicit field list in document searches * more fixes * use exclude_vectors=False * remove unneeded source call * add missing type hint (cherry picked from commit cac7ace) Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9.2, dense vectors aren't returned unless they are requested explicitly via the
_sourcequery parameter. To avoid this breaking change from affecting the DSL module, allSearchandAsyncSearchinstances created via theDocument.search()andAsyncDocument.search()methods are initialized with a_sourceproperty that includes the entire list of fields in the document.There are also a few minor adjustments to the tests for other apparent changes in 9.2.