Use an unbuffered queue for the sync bulk helper #3129
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
added
backport 8.19
backport 9.1
backport 9.2
and removed
backport 8.19
backport 9.1
labels
pquentin
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Thanks! LGTM.
(As you know, there's one minor difference: the async queue max size is 0, meaning it's only possible to put something in it successfully if another task is trying to get an element. However, that's not possible with queue.Queue as 0 means unbounded. Still, that's a much better approximation.)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
(cherry picked from commit 64f11cd)
miguelgrinberg
added a commit
that referenced
this pull request
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the queue used for the sync bulk helper equal in functionality to the ones we are using for asyncio and trio. An unbuffered queue makes more sense in this case because there is no benefit to accumulating all the elements in the queue faster than they can be processed.