Skip to content

Conversation

@miguelgrinberg
Copy link
Contributor

  • Renamed the _stability_warning decorator to _availability_warning
  • Added a second optional positional argument to it for the Visibility. If omitted it defaults to public.
  • If the endpoint is private, the warning reads "This API is private."
  • If an API is private and beta or experimental, the warning message for private is used.
  • If the visibility is not set or is not private, then the decorator works as before.

@miguelgrinberg miguelgrinberg force-pushed the add-private-warnings branch 3 times, most recently from 8593543 to e385be5 Compare December 2, 2025 16:47
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg merged commit bbca81a into elastic:main Dec 3, 2025
18 checks passed
@miguelgrinberg miguelgrinberg deleted the add-private-warnings branch December 3, 2025 11:06
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-3212-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bbca81a630b4b9bb0fcc26ed98c92fdd612a4387
# Push it to GitHub
git push --set-upstream origin backport-3212-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-3212-to-8.19.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-3212-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bbca81a630b4b9bb0fcc26ed98c92fdd612a4387
# Push it to GitHub
git push --set-upstream origin backport-3212-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-3212-to-9.1.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

The backport to 9.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-3212-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bbca81a630b4b9bb0fcc26ed98c92fdd612a4387
# Push it to GitHub
git push --set-upstream origin backport-3212-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2

Then, create a pull request where the base branch is 9.2 and the compare/head branch is backport-3212-to-9.2.

miguelgrinberg added a commit to miguelgrinberg/elasticsearch-py that referenced this pull request Dec 3, 2025
miguelgrinberg added a commit to miguelgrinberg/elasticsearch-py that referenced this pull request Dec 3, 2025
miguelgrinberg added a commit to miguelgrinberg/elasticsearch-py that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants