each_with_hit doesn't support includes to eager load associations

[sr3d]

collection.records.includes(:some_association).each_with_hit will error out: undefined method `each_with_hit' for #School::ActiveRecord_Relation:0x007fb13c51fe88

I looked around the source code and couldn't see it at all
(https://sourcegraph.com/github.com/elasticsearch/elasticsearch-rails@b500bf03d18f0852b9ee6ebc1aa15fe684f9a9f2/.tree/elasticsearch-model/lib/elasticsearch/model/response/records.rb). With Tire gem it's possible but somehow in the ES-Rails it's not.

[karmi]

@sr3d Yeah, I don't think this is possible, since the includes() changes the object, and we no longer have access to the search results... Would like to support it, but have no immediate idea how to do it now.

[karmi]

So, any news? I don't see this as immediately supportable/implementable. I'd lean to close this ticket.

[dimroc]

Just thought I'd give an update to this. I also ran into this, and quite frankly, eager loading (using includes(:association)) is critical to performance in a lot of scenarios.

I also contemplated modifying the elasticsearch-model gem, but ended up making a class called EagerPagination that solves this. The gist can be found here, and a blog post can be found here: https://gist.github.com/dimroc/ccc6c80c747ee8f957f3

http://www.dimroc.com/2014/11/12/eager-pagination-with-elasticsearch-rails/

Let me know what you think.

[alepore]

for reference, includes support was added: #472

[nerfologist]

Hello, I might be missing something here but the following still fails (on elasticsearch-model 5.0.1) due to includes returning a plain ActiveRecord::Relation:

users = User.search(params)
  .records            # custom ES-rails relation
  .includes(:address) # standard AR relation! No more custom methods
  .map_with_hit { |user, hit| user._score = hit._score } # NoMethodError

# ...
undefined method `map_with_hit' for #<User::ActiveRecord_Relation:0x007fb5a6107260>

Is there any workaround for this scenario? I need to include the Elasticsearch _score for serialization.

Right now I'm forced to remove the includes() call creating a N+1 situation.

Thanks in advance!