Skip to content

Conversation

@catwell
Copy link
Contributor

@catwell catwell commented Feb 6, 2021

The simplest solution to deal with the removal of types in ElasticSearch is simply to use single-type indices and not set document_type on models.

However Multimodel did not deal with that case and ended up calling a URL ending in my-index//_search instead of my-index/_search, which caused the types warning:

warning: 299 Elasticsearch-7.9.1-083627f112ba94dffc1232e8b42b73492789ef91 "[types removal] Specifying types in search requests is deprecated."

This PR fixes that issue.

@cla-checker-service
Copy link

cla-checker-service bot commented Feb 6, 2021

💚 CLA has been signed

@picandocodigo
Copy link
Member

Thank you for this contribution @catwell!

@picandocodigo picandocodigo merged commit cd9c309 into elastic:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants