Use URI::Generic to avoid edge-cases with ports #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the current implementation is provided a host that explicitly states a port number that is normally the default for its protocol (e.g.,
80onhttpor443onhttps), it overrides that explicit value with anil, effectively ignoring the explicit value and causing the client to attempt to connect on9200instead.This PR uses
URI::splitto split the string into its component parts and immediately uses them to construct aURI::Generic, which is not opinionated about ports and does not substitute default values. This eliminates the need to conditionally include the port.Resolves: #625