Fail explicitly with pull requests opened from forks #2580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e617f37.
flobernd
approved these changes
May 27, 2024
Member
flobernd
left a comment
flobernd
left a comment
There was a problem hiding this comment.
LGTM!
In the future, we could use the pull_request_target trigger instead.
This requires a little bit of extra work as we would have to check-out the user branch, copy only the specification (*.ts) files to the base branch and run the checks from here.
PRs that change the compiler itself can not be checked this way for security reasons, but it should be really really rare for an outside collaborator to change the compiler code.
flobernd
reviewed
May 27, 2024
.github/workflows/validate-pr.yml
Outdated
|
|
||
| steps: | ||
| - name: Check pull request was opened from branch | ||
| if: ${{ github.event.pull_request.head.repo.full_name != 'elastic/elasticsearch-specification' }} |
Member
There was a problem hiding this comment.
I think you can omit the template syntax here. Just the condition without ${{}} should be fine.
This reverts commit 14bcc30.
Member
Author
|
I confirmed in #2582 that we now get a failure with the right message. And that from branches, validations does run. Merging.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common problem, see #2555 and #2577 for recent examples. But not that common, and I tend to forget about it after a few months. Indeed, the current condition does not actually skip validation, and we don't want that anyway: we want to fail when we should have run validation but could not do it. And explain why we failed.
If the pull request was from an Elastic employee (95% of cases), then they can reopen it from a branch. If it was community-contributed, we need to do it for them (without closing the original pull request, thus preserving attribution when merging).
From a branch, the build was correctly triggered: https://github.com/elastic/elasticsearch-specification/actions/runs/9250931808/job/25445405796?pr=2580 (and failed as expected due to the extra file I have now removed).