Skip to content

Conversation

@l-trotta
Copy link
Contributor

As the documentation states, the parameters rule_type, name_type and languageset are only available for beider_morse encoder, so they should be optional.

@l-trotta l-trotta merged commit 65fc449 into main Aug 27, 2024
@l-trotta l-trotta deleted the phonetic-tf-optional branch August 27, 2024 10:55
@github-actions
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2813-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 65fc449981dd0d4912ab365bfc0cb8586204b48e
# Push it to GitHub
git push --set-upstream origin backport-2813-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2813-to-7.17.

github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
l-trotta added a commit that referenced this pull request Aug 27, 2024
(cherry picked from commit 65fc449)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
l-trotta added a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants