Add random sampler aggregation #2944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-trotta
reviewed
Sep 26, 2024
| * Must be greater than 0, less than 0.5, or exactly 1. | ||
| * The lower the probability, the fewer documents are matched. | ||
| */ | ||
| probability: float |
There was a problem hiding this comment.
Docs say float, but server says double
There was a problem hiding this comment.
Thanks, I should have checked that part, sorry. Done in 919eb559 (#2944).
Anaethelion
reviewed
Sep 26, 2024
| * | ||
| * A single bucket aggregation that randomly includes documents in the aggregated results. | ||
| * Sampling provides significant speed improvement at the cost of accuracy. | ||
| * @doc_id search-aggregations-pipeline-random-sampler-aggregation |
There was a problem hiding this comment.
Suggested change
| * @doc_id search-aggregations-pipeline-random-sampler-aggregation | |
| * @doc_id search-aggregations-bucket-random-sampler-aggregation |
There was a problem hiding this comment.
Thanks! I removed bucket too because it's not in the Elasticsearch URL for the random sampler aggregation:
- Random sampler: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-random-sampler-aggregation.html
- Sampler: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-sampler-aggregation.html
Done in 919eb559 (#2944).
github-actions bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
* Add random sampler aggregation * Address review comments * Run make contrib (cherry picked from commit 3c75c87)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Add random sampler aggregation * Address review comments * Run make contrib (cherry picked from commit 3c75c87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.