Skip to content

7.17 - Fix nodes security response #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

7.17 - Fix nodes security response #2956

merged 1 commit into from
Sep 27, 2024

Conversation

@l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Sep 27, 2024

If security is disabled all other values are null, so http has to be optional as well

pquentin
pquentin approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@l-trotta l-trotta merged commit 45d7e8c into 7.17 Sep 27, 2024
5 checks passed
@l-trotta l-trotta deleted the fix-nodes-info branch September 27, 2024 12:41
@l-trotta l-trotta mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pquentin pquentin pquentin approved these changes

@flobernd flobernd Awaiting requested review from flobernd

Assignees

No one assigned

Labels

specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@l-trotta @pquentin