Skip to content

Update rest-api-spec main #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2024
Merged

Update rest-api-spec main #3199

merged 2 commits into from
Dec 2, 2024

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 30, 2024

As titled.

@github-actions github-actions bot requested a review from a team as a code owner November 30, 2024 04:06
@l-trotta
Copy link
Contributor

l-trotta commented Dec 2, 2024

@pquentin this is because of this PR right? do you already have a fix ready?

@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 2, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
async_search.submit 🟢 7/7 7/7

You can validate this API yourself by using the make validate target.

@pquentin
Copy link
Member

pquentin commented Dec 2, 2024 •
edited
Loading

@pquentin this is because of this PR right? do you already have a fix ready?

@l-trotta Thanks! Fixed it here, #3200 and #3201.

l-trotta
l-trotta approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@l-trotta l-trotta merged commit 1552e85 into main Dec 2, 2024
7 checks passed
@l-trotta l-trotta deleted the automated/rest-api-spec-update-main branch December 2, 2024 12:42
@pquentin pquentin mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l-trotta l-trotta l-trotta approved these changes

@Anaethelion Anaethelion Awaiting requested review from Anaethelion

@ezimuel ezimuel Awaiting requested review from ezimuel

@flobernd flobernd Awaiting requested review from flobernd

@JoshMock JoshMock Awaiting requested review from JoshMock

@miguelgrinberg miguelgrinberg Awaiting requested review from miguelgrinberg

@picandocodigo picandocodigo Awaiting requested review from picandocodigo

@pquentin pquentin Awaiting requested review from pquentin

@srikanthmanvi srikanthmanvi Awaiting requested review from srikanthmanvi

@swallez swallez Awaiting requested review from swallez

@technige technige Awaiting requested review from technige

Assignees

No one assigned

Labels

specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@l-trotta @pquentin