Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Jan 3, 2025

If no backport is needed, we must apply skip-backport to pass CI.

And yes, this pull request must not be backported. :)

@pquentin pquentin added the skip-backport This pull request should not be backported label Jan 3, 2025
@pquentin pquentin requested a review from a team as a code owner January 3, 2025 08:03
@flobernd flobernd force-pushed the enforce-backports branch 6 times, most recently from afc0818 to dec4de1 Compare January 3, 2025 10:58
@flobernd flobernd added backport 8.17 backport 7.17 backport 8.19 skip-backport This pull request should not be backported and removed skip-backport This pull request should not be backported backport 7.17 backport 8.19 backport 8.17 labels Jan 3, 2025
@flobernd flobernd added backport 8.19 and removed skip-backport This pull request should not be backported labels Jan 3, 2025
@flobernd flobernd force-pushed the enforce-backports branch 2 times, most recently from 4a613da to c6553c1 Compare January 3, 2025 12:17
@pquentin pquentin added skip-backport This pull request should not be backported and removed backport 8.0 backport 8.19 backport 7.17 labels Jan 3, 2025
@pquentin
Copy link
Member Author

pquentin commented Jan 3, 2025

Thanks! LGTM. I can't approve as I'm technically the author.

nitpick: Should we fail when skip-backport and other backport labels are specified?

@flobernd flobernd merged commit 47075ba into main Jan 6, 2025
8 checks passed
@flobernd flobernd deleted the enforce-backports branch January 6, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-backport This pull request should not be backported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants