-
Notifications
You must be signed in to change notification settings - Fork 115
Add missing include_ccs_metadata to ES|QL query endpoints
#3743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
quux00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some changes.
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
@quux00 Do we require the documentation label? |
Not sure. I don't work in this repo much. I would check the README or ping someone in #devtools. |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
lcawl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates to the descriptions, they lgtm!
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
* Add missing `include_ccs_metadata` to ES|QL query endpoints * Address review comments * Regenerate output --------- Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit 6b15af9)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3743-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b15af9e6dfa7ee4f2d6e252b26dc68be0c97b7e
# Push it to GitHub
git push --set-upstream origin backport-3743-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3743-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b15af9e6dfa7ee4f2d6e252b26dc68be0c97b7e
# Push it to GitHub
git push --set-upstream origin backport-3743-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17Then, create a pull request where the |
* Add missing `include_ccs_metadata` to ES|QL query endpoints * Address review comments * Regenerate output --------- Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit 6b15af9)
* Add missing `include_ccs_metadata` to ES|QL query endpoints * Address review comments * Regenerate output --------- Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit 6b15af9)
|
Ack, will handle it. |
* Add missing `include_ccs_metadata` to ES|QL query endpoints * Address review comments * Regenerate output --------- Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit 6b15af9) # Conflicts: # output/schema/schema-serverless.json # output/schema/schema.json
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…3768) * Add missing `include_ccs_metadata` to ES|QL query endpoints * Address review comments * Regenerate output --------- Co-authored-by: lcawl <lcawley@elastic.co> (cherry picked from commit 6b15af9) Co-authored-by: Pawan Kartik <pawankartik.chitrapu@elastic.co> Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
This PR adds the missing include_ccs_metadata to ES|QL query endpoints such as
_queryand_query/async.