Skip to content

Conversation

@pawankartik-elastic
Copy link
Contributor

@pawankartik-elastic pawankartik-elastic commented Feb 6, 2025

This PR adds the missing include_ccs_metadata to ES|QL query endpoints such as _query and _query/async.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.async_query Missing test Missing test
esql.query 284/284 Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some changes.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.async_query Missing test Missing test
esql.query 284/284 Missing test

You can validate these APIs yourself by using the make validate target.

@pawankartik-elastic
Copy link
Contributor Author

pawankartik-elastic commented Feb 10, 2025

@quux00 Do we require the documentation label?

@quux00
Copy link
Contributor

quux00 commented Feb 10, 2025

@quux00 Do we require the documentation label?

Not sure. I don't work in this repo much. I would check the README or ping someone in #devtools.

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.async_query Missing test Missing test
esql.query 283/287 Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates to the descriptions, they lgtm!

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.async_query Missing test Missing test
esql.query 283/287 Missing test

You can validate these APIs yourself by using the make validate target.

@pawankartik-elastic pawankartik-elastic merged commit 6b15af9 into main Feb 11, 2025
8 checks passed
@pawankartik-elastic pawankartik-elastic deleted the pkar/async-include-ccs-metadata branch February 11, 2025 13:56
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
* Add missing `include_ccs_metadata` to ES|QL query endpoints

* Address review comments

* Regenerate output

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 6b15af9)
@github-actions
Copy link
Contributor

The backport to 8.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3743-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b15af9e6dfa7ee4f2d6e252b26dc68be0c97b7e
# Push it to GitHub
git push --set-upstream origin backport-3743-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16

Then, create a pull request where the base branch is 8.16 and the compare/head branch is backport-3743-to-8.16.

@github-actions
Copy link
Contributor

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3743-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b15af9e6dfa7ee4f2d6e252b26dc68be0c97b7e
# Push it to GitHub
git push --set-upstream origin backport-3743-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3743-to-8.17.

github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
* Add missing `include_ccs_metadata` to ES|QL query endpoints

* Address review comments

* Regenerate output

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 6b15af9)
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
* Add missing `include_ccs_metadata` to ES|QL query endpoints

* Address review comments

* Regenerate output

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 6b15af9)
@pawankartik-elastic
Copy link
Contributor Author

pawankartik-elastic commented Feb 11, 2025

Ack, will handle it.
Edit: Did not know about --no-fork; backport create a PR from my fork and since validation from forks is disabled, CI refused to run.

pawankartik-elastic added a commit that referenced this pull request Feb 11, 2025
…3769)

* Add missing `include_ccs_metadata` to ES|QL query endpoints

* Address review comments

* Regenerate output

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 6b15af9)

Co-authored-by: Pawan Kartik <pawankartik.chitrapu@elastic.co>
pawankartik-elastic added a commit that referenced this pull request Feb 11, 2025
…3770)

* Add missing `include_ccs_metadata` to ES|QL query endpoints

* Address review comments

* Regenerate output

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 6b15af9)

Co-authored-by: Pawan Kartik <pawankartik.chitrapu@elastic.co>
@pawankartik-elastic pawankartik-elastic restored the pkar/async-include-ccs-metadata branch February 11, 2025 16:10
pawankartik-elastic added a commit that referenced this pull request Feb 11, 2025
* Add missing `include_ccs_metadata` to ES|QL query endpoints

* Address review comments

* Regenerate output

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 6b15af9)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
@pawankartik-elastic
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

pawankartik-elastic added a commit that referenced this pull request Feb 12, 2025
…3772)

* Add missing `include_ccs_metadata` to ES|QL query endpoints

* Address review comments

* Regenerate output

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 6b15af9)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
pquentin added a commit that referenced this pull request Feb 13, 2025
…3768)

* Add missing `include_ccs_metadata` to ES|QL query endpoints

* Address review comments

* Regenerate output

---------

Co-authored-by: lcawl <lcawley@elastic.co>
(cherry picked from commit 6b15af9)

Co-authored-by: Pawan Kartik <pawankartik.chitrapu@elastic.co>
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants