Skip to content

[Inference API] Adds chunking_settings to PUT inference API #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

[Inference API] Adds chunking_settings to PUT inference API #3781

merged 2 commits into from
Feb 18, 2025

Conversation

@szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Feb 18, 2025 •
edited
Loading

Overview

This PR adds the chunking_settings parameter to the inference API spec. The parameter was introduced in 8.16.

@szabosteve szabosteve requested a review from davidkyle February 18, 2025 09:47
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete ⚪ Missing test Missing test
inference.get 🟢 1/1 1/1
inference.inference ⚪ Missing test Missing test
inference.put ⚪ Missing test Missing test
inference.stream_inference ⚪ Missing test Missing test
inference.unified_inference ⚪ Missing test Missing test
inference.update ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@szabosteve szabosteve requested a review from pquentin February 18, 2025 10:29
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete ⚪ Missing test Missing test
inference.get 🟢 1/1 1/1
inference.inference ⚪ Missing test Missing test
inference.put ⚪ Missing test Missing test
inference.stream_inference ⚪ Missing test Missing test
inference.unified_inference ⚪ Missing test Missing test
inference.update ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@szabosteve szabosteve marked this pull request as ready for review February 18, 2025 10:31
pquentin
pquentin approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not checked that every property is correct, but the way the change was made is correct.

@szabosteve szabosteve merged commit bf2a5ca into main Feb 18, 2025
13 of 18 checks passed
@szabosteve szabosteve deleted the szabosteve/inference-chunking branch February 18, 2025 13:15
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
@szabosteve @github-actions
[Inference API] Adds chunking_settings to PUT inference API (#3781)
a9c3161 
* [Inference API] Adds chunking_settings to PUT inference API.

* [Inference API] Make contrib.

(cherry picked from commit bf2a5ca)
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
@szabosteve @github-actions
[Inference API] Adds chunking_settings to PUT inference API (#3781)
79e2e44 
* [Inference API] Adds chunking_settings to PUT inference API.

* [Inference API] Make contrib.

(cherry picked from commit bf2a5ca)
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
@szabosteve @github-actions
[Inference API] Adds chunking_settings to PUT inference API (#3781)
b34f943 
* [Inference API] Adds chunking_settings to PUT inference API.

* [Inference API] Make contrib.

(cherry picked from commit bf2a5ca)
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
@szabosteve @github-actions
[Inference API] Adds chunking_settings to PUT inference API (#3781)
aa74066 
* [Inference API] Adds chunking_settings to PUT inference API.

* [Inference API] Make contrib.

(cherry picked from commit bf2a5ca)
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
@szabosteve @github-actions
[Inference API] Adds chunking_settings to PUT inference API (#3781)
8a9157a 
* [Inference API] Adds chunking_settings to PUT inference API.

* [Inference API] Make contrib.

(cherry picked from commit bf2a5ca)
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
Merged
szabosteve added a commit that referenced this pull request Feb 18, 2025
@github-actions @szabosteve
[Inference API] Adds chunking_settings to PUT inference API (#3781) (#…
f4eb5bc 
…3786)

* [Inference API] Adds chunking_settings to PUT inference API.

* [Inference API] Make contrib.

(cherry picked from commit bf2a5ca)

Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
szabosteve added a commit that referenced this pull request Feb 18, 2025
@github-actions @szabosteve
[Inference API] Adds chunking_settings to PUT inference API (#3781) (#…
a7172fa 
…3785)

* [Inference API] Adds chunking_settings to PUT inference API.

* [Inference API] Make contrib.

(cherry picked from commit bf2a5ca)

Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
szabosteve added a commit that referenced this pull request Feb 18, 2025
@github-actions @szabosteve
[Inference API] Adds chunking_settings to PUT inference API (#3781) (#…
7f8c952 
…3784)

* [Inference API] Adds chunking_settings to PUT inference API.

* [Inference API] Make contrib.

(cherry picked from commit bf2a5ca)

Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
szabosteve added a commit that referenced this pull request Feb 18, 2025
@github-actions @szabosteve
[Inference API] Adds chunking_settings to PUT inference API (#3781) (#…
89f6986 
…3783)

* [Inference API] Adds chunking_settings to PUT inference API.

* [Inference API] Make contrib.

(cherry picked from commit bf2a5ca)

Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
szabosteve added a commit that referenced this pull request Feb 19, 2025
@github-actions @szabosteve
[Inference API] Adds chunking_settings to PUT inference API (#3781) (#…
95d614d 
…3782)

* [Inference API] Adds chunking_settings to PUT inference API.

* [Inference API] Make contrib.

(cherry picked from commit bf2a5ca)

Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pquentin pquentin pquentin approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

@davidkyle davidkyle Awaiting requested review from davidkyle

Assignees

No one assigned

Labels

backport 8.16 backport 8.17 backport 8.18 backport 8.19 backport 9.0 specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@szabosteve @pquentin @jonathan-buttner