Skip to content

[Backport 9.0] Ignore errors from private APIs #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[Backport 9.0] Ignore errors from private APIs #3804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions compiler/src/steps/validate-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ enum JsonEvent {
array = 'array'
}

const privateNamespaces = ['_internal', 'profiling']

/**
* Validates the internal consistency of the model (doesn't check the json spec)
*
Expand Down Expand Up @@ -208,6 +210,11 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
function validateEndpoint (endpoint: model.Endpoint): void {
setRootContext(endpoint.name, 'request')

// Skip validation for internal endpoints
if (privateNamespaces.some(ns => endpoint.name.startsWith(ns))) {
return
}

if (endpoint.request == null) {
if (endpoint.response == null) {
modelError('Missing request & response')
Expand Down
60 changes: 0 additions & 60 deletions output/schema/validation-errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,41 +1,5 @@
{
"endpointErrors": {
"_internal.delete_desired_balance": {
"request": [
"Missing request & response"
],
"response": []
},
"_internal.delete_desired_nodes": {
"request": [
"Missing request & response"
],
"response": []
},
"_internal.get_desired_balance": {
"request": [
"Missing request & response"
],
"response": []
},
"_internal.get_desired_nodes": {
"request": [
"Missing request & response"
],
"response": []
},
"_internal.prevalidate_node_removal": {
"request": [
"Missing request & response"
],
"response": []
},
"_internal.update_desired_nodes": {
"request": [
"Missing request & response"
],
"response": []
},
"async_search.submit": {
"request": [
"Request: query parameter 'keep_alive' does not exist in the json spec",
Expand Down Expand Up @@ -292,30 +256,6 @@
],
"response": []
},
"profiling.flamegraph": {
"request": [
"Missing request & response"
],
"response": []
},
"profiling.stacktraces": {
"request": [
"Missing request & response"
],
"response": []
},
"profiling.status": {
"request": [
"Missing request & response"
],
"response": []
},
"profiling.topn_functions": {
"request": [
"Missing request & response"
],
"response": []
},
"reindex": {
"request": [
"Request: query parameter 'require_alias' does not exist in the json spec",
Expand Down