Skip to content

Conversation

@l-trotta
Copy link
Contributor

type is currently required in BulkIndexByScrollFailure, but it's actually never serialized there, only inside the cause field, where we already have it correctly as a required field.
Server code: BulkByScrollResponse, failures toXcontent, Exception toXcontent -> showing where type is.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@l-trotta l-trotta merged commit 960d65a into main Feb 24, 2025
18 checks passed
@l-trotta l-trotta deleted the failures-error-type-fix branch February 24, 2025 16:42
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)
l-trotta added a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
l-trotta added a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
l-trotta added a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
l-trotta added a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
l-trotta added a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)

Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants