Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 28, 2025

This PR removes the use of /master/ URLs in the overlays and readmes. It also adds doc_id values to new APIs so they don't default to the old master URLs.

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.migrate_to_data_stream Missing test Missing test
indices.modify_data_stream Missing test Missing test
indices.promote_data_stream Missing test Missing test
indices.put_alias 🔴 58/58 20/58
indices.put_data_lifecycle Missing test Missing test
indices.put_index_template 🔴 59/68 68/68
indices.update_aliases 🔴 26/26 7/26
indices.validate_query 🟢 12/12 12/12

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review February 28, 2025 21:01
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗

@lcawl lcawl merged commit 96fb071 into main Mar 3, 2025
13 of 14 checks passed
@lcawl lcawl deleted the rm-master branch March 3, 2025 17:18
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3858-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 96fb0719f53bd2f289639d9c5dc682ca96fd7c5c
# Push it to GitHub
git push --set-upstream origin backport-3858-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3858-to-8.x.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3858-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 96fb0719f53bd2f289639d9c5dc682ca96fd7c5c
# Push it to GitHub
git push --set-upstream origin backport-3858-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-3858-to-8.18.

github-actions bot pushed a commit that referenced this pull request Mar 3, 2025
(cherry picked from commit 96fb071)
lcawl added a commit that referenced this pull request Mar 3, 2025
(cherry picked from commit 96fb071)
@lcawl
Copy link
Contributor Author

lcawl commented Mar 3, 2025

💚 All backports created successfully

Status Branch Result
9.0

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Mar 3, 2025
(cherry picked from commit 96fb071)
@lcawl
Copy link
Contributor Author

lcawl commented Mar 3, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Mar 3, 2025
(cherry picked from commit 96fb071)
@lcawl
Copy link
Contributor Author

lcawl commented Mar 3, 2025

💚 All backports created successfully

Status Branch Result
8.18

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Mar 3, 2025
(cherry picked from commit 96fb071)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Mar 4, 2025
lcawl added a commit that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants