Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Mar 5, 2025

This fixes validation for cluster.put_component_template.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

}

/**
* @es_quirk This enum is a boolean that evolved into a tri-state enum. True and False have
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Out of curiosity, does ES accept true and false as string too? This seems to be the case for the other enums evolved from a boolean.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pquentin pquentin merged commit a88eef2 into main Mar 5, 2025
14 checks passed
@pquentin pquentin deleted the subobjects-auto branch March 5, 2025 09:33
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)
pquentin added a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Mar 5, 2025
(cherry picked from commit a88eef2)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants