Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 9, 2025

This PR updates the URLs for Docs V3 in:

  • the table.csv file, which is used to resolve the doc_id and ext_doc_id values in the OpenAPI documents, for example.
  • overlay files, which are used to append extra details to the generated OpenAPI documents
  • specifications, where they were linking to URLs directly

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
fleet.msearch Missing test Missing test
fleet.search Missing test Missing test
nodes.get_repositories_metering_info Missing test Missing test
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 28/28 28/28

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from a team April 9, 2025 22:50
@lcawl lcawl changed the title Update URLs in table.csv Update URLs for Docs V3 Apr 9, 2025
@lcawl lcawl marked this pull request as ready for review April 9, 2025 22:50
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
fleet.msearch Missing test Missing test
fleet.search Missing test Missing test
nodes.get_repositories_metering_info Missing test Missing test
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 28/28 28/28

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes, LGTM!

@lcawl lcawl merged commit 90fbed0 into main Apr 10, 2025
8 checks passed
@lcawl lcawl deleted the url-redirects branch April 10, 2025 15:25
@github-actions
Copy link
Contributor

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4255-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 90fbed03ba8c2eed4b4d246ce9f15d7236b230fc
# Push it to GitHub
git push --set-upstream origin backport-4255-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-4255-to-9.0.

lcawl added a commit that referenced this pull request Apr 10, 2025
(cherry picked from commit 90fbed0)
@lcawl
Copy link
Contributor Author

lcawl commented Apr 10, 2025

💚 All backports created successfully

Status Branch Result
9.0

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Apr 11, 2025
(cherry picked from commit 90fbed0)
lcawl added a commit that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants