Add TDigestExecutionHint to metric aggregations #4600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
commented
Jun 17, 2025
Comment on lines
+182
to
+187
| /** | ||
| * The default implementation of TDigest is optimized for performance, scaling to millions or even billions of sample values while maintaining acceptable accuracy levels (close to 1% relative error for millions of samples in some cases). | ||
| * To use an implementation optimized for accuracy, set this parameter to high_accuracy instead. | ||
| * @server_default default | ||
| */ | ||
| execution_hint?: TDigestExecutionHint |
There was a problem hiding this comment.
Comment on lines
+62
to
+67
| /** | ||
| * The default implementation of TDigest is optimized for performance, scaling to millions or even billions of sample values while maintaining acceptable accuracy levels (close to 1% relative error for millions of samples in some cases). | ||
| * To use an implementation optimized for accuracy, set this parameter to high_accuracy instead. | ||
| * @server_default default | ||
| */ | ||
| execution_hint?: TDigestExecutionHint |
There was a problem hiding this comment.
Comment on lines
+257
to
260
| export enum TDigestExecutionHint { | ||
| default, | ||
| high_accuracy | ||
| } |
There was a problem hiding this comment.
Comment on lines
+249
to
+254
| /** | ||
| * The default implementation of TDigest is optimized for performance, scaling to millions or even billions of sample values while maintaining acceptable accuracy levels (close to 1% relative error for millions of samples in some cases). | ||
| * To use an implementation optimized for accuracy, set this parameter to high_accuracy instead. | ||
| * @server_default default | ||
| */ | ||
| execution_hint?: TDigestExecutionHint |
There was a problem hiding this comment.
flobernd
approved these changes
Jun 17, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
(cherry picked from commit 7efcc50)
pquentin
added a commit
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 8 validation errors when validating the Search API.