Skip to content

validate-pr: report diff instead of current status #4642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2025
Merged

validate-pr: report diff instead of current status #4642

merged 4 commits into from
Jun 23, 2025

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Jun 23, 2025 •
edited
Loading

Builds on top of the private https://github.com/elastic/clients-flight-recorder/pull/1323 PR. When removing stuff from specification/ml/_types/Bucket.ts and specification/snapshot/get/SnapshotGetRequest.ts, I get this:

API Status Request Response
ml.get_buckets 🟢 → 🔴 14/14 14/14 → 11/14
snapshot.get 🟢 → 🔴 16/16 → 13/16 16/16

@pquentin pquentin requested a review from a team as a code owner June 23, 2025 07:29
flobernd
flobernd approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very nice.

@pquentin pquentin requested review from a team as code owners June 23, 2025 09:28
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

Following you can find the validation changes for the APIs you have modified.

API Status Request Response
ml.get_buckets 🟢 → 🔴 14/14 14/14 → 11/14
snapshot.get 🟢 → 🔴 16/16 → 10/16 16/16

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit 73d7cb4 into main Jun 23, 2025
8 checks passed
@pquentin pquentin deleted the validation-diff branch June 23, 2025 09:44
github-actions bot pushed a commit that referenced this pull request Jun 23, 2025
@pquentin @github-actions
validate-pr: report diff instead of current status (#4642)
73fcb5d 
* validate-pr: report diff instead of current status

* Introduce a few errors on purpose

* Revert "Introduce a few errors on purpose"

This reverts commit 3e5d7e1.

(cherry picked from commit 73d7cb4)
@github-actions github-actions bot mentioned this pull request Jun 23, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 23, 2025
@pquentin @github-actions
validate-pr: report diff instead of current status (#4642)
536405c 
* validate-pr: report diff instead of current status

* Introduce a few errors on purpose

* Revert "Introduce a few errors on purpose"

This reverts commit 3e5d7e1.

(cherry picked from commit 73d7cb4)
@github-actions github-actions bot mentioned this pull request Jun 23, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 23, 2025
@pquentin @github-actions
validate-pr: report diff instead of current status (#4642)
5df574c 
* validate-pr: report diff instead of current status

* Introduce a few errors on purpose

* Revert "Introduce a few errors on purpose"

This reverts commit 3e5d7e1.

(cherry picked from commit 73d7cb4)
@github-actions github-actions bot mentioned this pull request Jun 23, 2025
Merged
pquentin added a commit that referenced this pull request Jun 24, 2025
@github-actions @pquentin
validate-pr: report diff instead of current status (#4642) (#4643)
b2dc43c 
* validate-pr: report diff instead of current status

* Introduce a few errors on purpose

* Revert "Introduce a few errors on purpose"

This reverts commit 3e5d7e1.

(cherry picked from commit 73d7cb4)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Jun 24, 2025
@github-actions @pquentin
validate-pr: report diff instead of current status (#4642) (#4645)
4cd7a7d 
* validate-pr: report diff instead of current status

* Introduce a few errors on purpose

* Revert "Introduce a few errors on purpose"

This reverts commit 3e5d7e1.

(cherry picked from commit 73d7cb4)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Jun 24, 2025
@github-actions @pquentin
validate-pr: report diff instead of current status (#4642) (#4644)
677be69 
* validate-pr: report diff instead of current status

* Introduce a few errors on purpose

* Revert "Introduce a few errors on purpose"

This reverts commit 3e5d7e1.

(cherry picked from commit 73d7cb4)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
@pquentin pquentin mentioned this pull request Jun 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flobernd flobernd flobernd approved these changes

@l-trotta l-trotta l-trotta approved these changes

Assignees

No one assigned

Labels

backport 8.18 backport 8.19 backport 9.0 specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pquentin @flobernd @l-trotta