Skip to content

Fix validation for _global APIs #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Fix validation for _global APIs #4659

merged 1 commit into from
Jun 24, 2025

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Jun 24, 2025

The existing namespace computation was too naive. We now use this version instead:

export function getNamespace (api) {
  if (api.includes('.')) return api.split('.')[0]
  return 'global'
}

@pquentin
Fix validation for _global APIs
aefa866 
The existing namespace computation was too naive.
@pquentin pquentin requested a review from a team as a code owner June 24, 2025 10:29
@pquentin pquentin added skip-backport This pull request should not be backported backport 8.19 backport 8.18 backport 9.0 and removed skip-backport This pull request should not be backported labels Jun 24, 2025
@pquentin pquentin merged commit bd228bb into main Jun 24, 2025
16 of 17 checks passed
@pquentin pquentin deleted the fix-global-validation branch June 24, 2025 10:33
github-actions bot pushed a commit that referenced this pull request Jun 24, 2025
@pquentin @github-actions
Fix validation for _global APIs (#4659)
b679d01 
The existing namespace computation was too naive.

(cherry picked from commit bd228bb)
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 24, 2025
@pquentin @github-actions
Fix validation for _global APIs (#4659)
1a591e3 
The existing namespace computation was too naive.

(cherry picked from commit bd228bb)
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 24, 2025
@pquentin @github-actions
Fix validation for _global APIs (#4659)
be67575 
The existing namespace computation was too naive.

(cherry picked from commit bd228bb)
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Merged
pquentin added a commit that referenced this pull request Jun 24, 2025
@github-actions @pquentin
Fix validation for _global APIs (#4659) (#4662)
21ce87e 
The existing namespace computation was too naive.

(cherry picked from commit bd228bb)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Jun 24, 2025
@github-actions @pquentin
Fix validation for _global APIs (#4659) (#4661)
c9fb3a9 
The existing namespace computation was too naive.

(cherry picked from commit bd228bb)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request Jun 24, 2025
@github-actions @pquentin
Fix validation for _global APIs (#4659) (#4660)
a5300a4 
The existing namespace computation was too naive.

(cherry picked from commit bd228bb)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l-trotta l-trotta l-trotta approved these changes

Assignees

No one assigned

Labels

backport 8.18 backport 8.19 backport 9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pquentin @l-trotta