Skip to content

[Backport 9.0] Fix validation for _global APIs #4662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

[Backport 9.0] Fix validation for _global APIs #4662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/validate-pr/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ async function run() {
ci: false,
verbose: false
})
const [namespace, _method] = api.split('.')
const namespace = getNamespace(api)
// Asked to validate a specific API, so we only store that one
reports.set(api, report.get(namespace)[0])
}
Expand All @@ -120,7 +120,7 @@ async function run() {
verbose: false
})

const [namespace, _method] = api.split('.')
const namespace = getNamespace(api)
// Asked to validate a specific API, so we only store that one
reports.set(api, report.get(namespace)[0])
}
Expand Down Expand Up @@ -162,7 +162,6 @@ function getApi (file) {
return file.split('/').slice(1, 3).filter(s => !privateNames.includes(s)).filter(Boolean).join('.')
}


function findBaselineReport(apiName, baselineValidation) {
const [namespace, method] = apiName.split('.')

Expand Down