Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 2, 2025

Relates to #4628

This PR updates the "make transform-to-openapi" and "make transform-to-openapi-for docs" commands to include the "--branch" parameter that was created in #4722. The parameter affects the resolution of URLs that use "{branch}" in table.csv.

NOTE:

@lcawl lcawl requested a review from a team July 2, 2025 17:07
@lcawl lcawl requested review from a team as code owners July 2, 2025 17:07
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Following you can find the validation changes for the API you have modified.

API Status Request Response
esql.query 🟢 320/320 → 314/314 0/0

You can validate this API yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. I've changed Makefile to use a variable to make sure we don't miss one line in the future update.

@pquentin pquentin changed the title [OpenAPI] Add --branch for 8.19 docs [8.19] [OpenAPI] Add --branch for 8.19 docs Jul 4, 2025
@pquentin pquentin merged commit 93a858d into 8.19 Jul 4, 2025
7 checks passed
@pquentin pquentin deleted the 819-docs-branch branch July 4, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants