Skip to content

[8.18] Stop generating errors for body inheritance (#3292) #4989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

[8.18] Stop generating errors for body inheritance (#3292) #4989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions compiler/src/steps/validate-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,11 +455,6 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
context.pop()

context.push('body')
if (typeDef.inherits != null && typeDef.body.kind !== 'properties') {
if (fqn(typeDef.inherits.type) !== '_types:RequestBase') {
modelError('A request with inherited properties must have a PropertyBody')
}
}
switch (typeDef.body.kind) {
case 'properties':
validateProperties(typeDef.body.properties, openGenerics, inheritedProps)
Expand Down
147 changes: 1 addition & 146 deletions output/schema/validation-errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,152 +14,7 @@
},
"cat.aliases": {
"request": [
"Request: query parameter 'master_timeout' does not exist in the json spec",
"request definition cat.aliases:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.allocation": {
"request": [
"request definition cat.allocation:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.component_templates": {
"request": [
"request definition cat.component_templates:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.count": {
"request": [
"request definition cat.count:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.fielddata": {
"request": [
"request definition cat.fielddata:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.health": {
"request": [
"request definition cat.health:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.indices": {
"request": [
"request definition cat.indices:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.master": {
"request": [
"request definition cat.master:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.ml_data_frame_analytics": {
"request": [
"request definition cat.ml_data_frame_analytics:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.ml_datafeeds": {
"request": [
"request definition cat.ml_datafeeds:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.ml_jobs": {
"request": [
"request definition cat.ml_jobs:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.ml_trained_models": {
"request": [
"request definition cat.ml_trained_models:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.nodeattrs": {
"request": [
"request definition cat.nodeattrs:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.nodes": {
"request": [
"request definition cat.nodes:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.pending_tasks": {
"request": [
"request definition cat.pending_tasks:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.plugins": {
"request": [
"request definition cat.plugins:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.recovery": {
"request": [
"request definition cat.recovery:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.repositories": {
"request": [
"request definition cat.repositories:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.segments": {
"request": [
"request definition cat.segments:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.shards": {
"request": [
"request definition cat.shards:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.snapshots": {
"request": [
"request definition cat.snapshots:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.tasks": {
"request": [
"request definition cat.tasks:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.templates": {
"request": [
"request definition cat.templates:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.thread_pool": {
"request": [
"request definition cat.thread_pool:Request / body - A request with inherited properties must have a PropertyBody"
],
"response": []
},
"cat.transforms": {
"request": [
"request definition cat.transforms:Request / body - A request with inherited properties must have a PropertyBody"
"Request: query parameter 'master_timeout' does not exist in the json spec"
],
"response": []
},
Expand Down