Run custom eslint rules as part of CI

[pquentin]

Right now, all rules pass, but this needs to be enforced:

• by setting the severity to error
• and running lint as part of make contrib, which runs in CI.

[github-actions]

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

[JoshMock]

Makes sense! I thought make validate had the same effect in CI, but I guess that's not the case.

[pquentin]

Right! make validate is only used by developers. Validation in CI happens with https://github.com/elastic/elasticsearch-specification/tree/main/.github/validate-pr

[github-actions]

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5199-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89d9381b5feb7757605d01e47bc868b0acc7fb70
# Push it to GitHub
git push --set-upstream origin backport-5199-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-5199-to-9.0.

[github-actions]

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5199-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89d9381b5feb7757605d01e47bc868b0acc7fb70
# Push it to GitHub
git push --set-upstream origin backport-5199-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-5199-to-9.1.