-
Notifications
You must be signed in to change notification settings - Fork 115
Add project_routing query param to _search and _async_search #5259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…c_search endpoints, but only for serverless
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
|
@quux00 thanks! waiting for the server side PR to be merged. just to be sure, is the only value allowed |
| * _alias:_origin | ||
| * _alias:*pr* | ||
| * Supported in serverless only. | ||
| * @availability serverless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see these on another PR:
@availability serverless stability=stable visibility=public
Do I need to add those? What are the other possible values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are optional, but nice to have. possible values:
- stability: stable, experimental, unknown
- visibility: public, private, feature_flag
in case of visibility=feature_flag you can also add an optional feature_flag={name of the feature flag}.
lastly there's since, which indicates (for stack) the version where the endpoint/field was introduced.
complete example:
| * @availability stack since=8.4.0 visibility=feature_flag feature_flag=es.index_mode_feature_flag_registered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it thanks. I'll add that in the next push.
For now that is the only allowed entry, but in the future we will allow arbitrary key/value pairs with AND/OR/NOT booleans and boolean groupings, using Lucene query syntax, so I don't think we want additional constraints in the spec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quux00 is this all the APIs we know of for now that will support CPS project routing rules? If not, the sooner we get those into the spec the better, as they'll be necessary to support the middleware Kibana needs.
Otherwise, LGTM.
No, there are several more. Those PR(s) will be out later this week. |
Adds the project_routing query param to the _search and _async_search endpoints
but only in serverless behind the feature flag "serverless.cross_project.enabled".
This param is not available in stateful ("stack").