- 
                Notifications
    You must be signed in to change notification settings 
- Fork 116
Feature/update authenticate specs #5270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| export class AuthenticateApiKey { | ||
| id: Id | ||
| name?: Name | ||
| managed_by: AuthenticateApiKeyManagedBy | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slightly verbose name to avoid a naming conflict that comes up when using ManagedBy:
ManagedBy is present in multiple namespaces: indices._types and security.authenticate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you we have plans to add managed_by to other APIs? If yes it should be added under specification/security so that it's not specific to this API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll raise this internally but to my knowledge, this is specific to this api currently. Will refactor if we come back here again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thank you! Actually, a refactor here would be a breaking change for some clients that expose the specification hierarchy, which is why I asked.
| Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Updating API spec for the
/_security/_authenticateAPI to add a couple of new fields,internalandmanaged_bythat are applicable to API Keys