Skip to content

Feature/update authenticate specs #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

Feature/update authenticate specs #5270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceed550
add internal and managed_by
ankit--sethi Sep 8, 2025
eebabc8
add internal and managed_by
ankit--sethi Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion output/openapi/elasticsearch-openapi.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 20 additions & 1 deletion output/openapi/elasticsearch-serverless-openapi.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 39 additions & 1 deletion output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions specification/security/authenticate/SecurityAuthenticateResponse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,11 @@ export class Response {
export class AuthenticateApiKey {
id: Id
name?: Name
managed_by: AuthenticateApiKeyManagedBy
Copy link
Contributor Author

@ankit--sethi ankit--sethi Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slightly verbose name to avoid a naming conflict that comes up when using ManagedBy:

ManagedBy is present in multiple namespaces: indices._types and security.authenticate

Copy link
Member

@pquentin pquentin Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you we have plans to add managed_by to other APIs? If yes it should be added under specification/security so that it's not specific to this API.

Copy link
Contributor Author

@ankit--sethi ankit--sethi Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll raise this internally but to my knowledge, this is specific to this api currently. Will refactor if we come back here again!

Copy link
Member

@pquentin pquentin Sep 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thank you! Actually, a refactor here would be a breaking change for some clients that expose the specification hierarchy, which is why I asked.

internal: boolean
}

export enum AuthenticateApiKeyManagedBy {
cloud,
elasticsearch
}
Loading